uros-b commented on code in PR #58606: URL: https://github.com/apache/spark/pull/58606#discussion_r3978247651
########## sql/core/src/test/resources/sql-tests/analyzer-results/identifier-clause-legacy.sql.out: ########## @@ -3177,3 +3177,466 @@ DROP SCHEMA identifier_clause_test_schema -- !query analysis DropNamespace false, false +- ResolvedNamespace V2SessionCatalog(spark_catalog), [identifier_clause_test_schema] + Review Comment: identifier-clause-legacy.sql ALTERs a permanent view under the flag and drops it without SELECT. prepareTable / alterPermanentView never pass the recorded names into generateViewProperties, so the view stays unqueryable. Either persist the names or drop the implication that the flag repairs IDENTIFIER views. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
