cloud-fan commented on code in PR #58606:
URL: https://github.com/apache/spark/pull/58606#discussion_r3999376498
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveIdentifierClause.scala:
##########
@@ -69,14 +79,26 @@ class ResolveIdentifierClause(earlyBatches:
Seq[RuleExecutor[LogicalPlan]#Batch]
referredTempVars.get ++= collectTemporaryVariablesInLogicalPlan(p)
}
- executor.execute(p.planBuilder.apply(
+ val resolvedPlan = executor.execute(p.planBuilder.apply(
IdentifierResolution.evalIdentifierExpr(p.identifierExpr),
p.children))
+ // Only record the variables when the identifier names something
inside a view body. When it
Review Comment:
The current head now distinguishes generic recording, target-name exclusion,
temporary-view metadata, and persisted-view validation. I called out the
remaining narrower wording overstatements separately.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"inline:3995050250","thread_id":"inline:3995050250","verdict_sha256":"12b7f981564f986cf8d4f4a9b51e54d32eca69438988a6670d47d8c183663030"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
