LukaZdravic opened a new pull request, #58742:
URL: https://github.com/apache/spark/pull/58742

   ### What changes were proposed in this pull request?
   
   This is a test-only change that adds planner-stage (physical-planning / 
strategy) coverage for the `ASOF JOIN` sort-merge operator:
   
   - **`PlannerSuite`** — a new test constructs a no-equi-key 
`SortMergeAsOfJoinExec` and runs `EnsureRequirements`, asserting that both 
sides are shuffled to a single partition. This exercises the `AllTuples` branch 
of the operator's `requiredChildDistribution` (used when the join has no 
equi-keys), following the existing `SortMergeJoinExec` distribution tests in 
the same suite (SPARK-24495 / SPARK-27485).
   - **`SortMergeAsOfJoinSuite`** — a new test checks that a null-safe equi-key 
(`<=>`) in `ON` is routed to the residual condition rather than treated as an 
equi-key, so rows whose key is `NULL` on both sides do match. This is the 
counterpart to the existing `EqualTo` case where null keys never match, and 
mirrors `InnerJoinSuite`'s "inner join, null safe" test.
   
   No production code is changed.
   
   ### Why are the changes needed?
   
   The `AsOfJoinSelection` strategy and `SortMergeAsOfJoinExec` operator were 
exercised end-to-end for result correctness, but two planner-stage behaviors 
had no test: (1) the operator's custom `requiredChildDistribution` that forces 
a single partition when there are no equi-keys, and (2) the strategy's handling 
of `EqualNullSafe` in `ON`. Sibling join operators cover the analogous 
behaviors; this brings `ASOF JOIN` up to the same bar.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   New unit tests. Ran `PlannerSuite` and `SortMergeAsOfJoinSuite` locally (via 
Maven); all tests pass.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to