vranes commented on code in PR #58742:
URL: https://github.com/apache/spark/pull/58742#discussion_r4005060704
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala:
##########
@@ -746,6 +746,29 @@ class PlannerSuite extends SharedSparkSession with
AdaptiveSparkPlanHelper {
}
}
+ test("SPARK-59438: as-of join with no equi-keys requires a single
partition") {
Review Comment:
We should also assert requiredChildOrdering in both of these tests.
```
// no-equi-key: ordering is just the sort exprs
assert(asOfExec.requiredChildOrdering ==
Seq(Seq(orderingA), Seq(orderingB)))
```
```
// equi-key: ordering is keys ++ sortExprs, keys first
assert(asOfExec.requiredChildOrdering ==
Seq(Seq(SortOrder(keyA, Ascending), SortOrder(sortExprL, Ascending)),
Seq(SortOrder(keyB, Ascending), SortOrder(sortExprR, Ascending))))
```
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala:
##########
@@ -746,6 +746,29 @@ class PlannerSuite extends SharedSparkSession with
AdaptiveSparkPlanHelper {
}
}
+ test("SPARK-59438: as-of join with no equi-keys requires a single
partition") {
Review Comment:
We should have a test for equi-keys case too, asserting HashPartitioning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
