nchammas opened a new pull request, #58769:
URL: https://github.com/apache/spark/pull/58769

   ### What changes were proposed in this pull request?
   
   Explicitly trigger the `pyspark-connect` test module on changes to 
`sbin/start-connect-server.sh`.
   
   ### Why are the changes needed?
   
   This script is called here as part of PR CI: 
https://github.com/apache/spark/blob/24c15b0383f21b2e80b27435617f16933236491c/.github/workflows/build_and_test.yml#L757
   
   This is run when any `pyspark` module is activated: 
https://github.com/nchammas/spark/blob/2d309efaf85b18d932acd837e81e60f83d6bad57/.github/workflows/build_and_test.yml#L110-L115
   
   By adding this sbin script to the `pyspark-connect` module, we in turn 
activate the `pyspark_connect_old_client` test in the `build_and_test.yml` 
workflow.
   
   It's a bit of a clunky relationship, and in the future I would like to 
refactor this so we are doing less in the workflow YAML and more in 
`sparktestsupport`. But for now, adding this line to the `pyspark-connect` 
makes the relationship more explicit.
   
   The `stop-connect-server.sh` script is not tested by any part of CI as far 
as I can tell, so I've left it alone for now.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   CI
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to