rpnkv commented on code in PR #54644:
URL: https://github.com/apache/spark/pull/54644#discussion_r4007731694


##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##########
@@ -1436,6 +1436,24 @@ class QueryExecutionErrorsSuite
       parameters = Map("dataType" -> "PhysicalCalendarIntervalType"))
   }
 
+  test("SPARK-49634: Numeric value out of range") {

Review Comment:
   Thanks for the comment.
   I checked QueryExecutionAnsiErrorsSuite — there's already a similar test 
there. And from what I understand, the program doesn't fail with an exception 
when ANSI mode is off. So testing this behavior in QueryExecutionErrorsSuite 
doesn't seem appropriate either — would you agree?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to