rpnkv commented on code in PR #54644:
URL: https://github.com/apache/spark/pull/54644#discussion_r3917048157
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##########
@@ -1436,6 +1436,24 @@ class QueryExecutionErrorsSuite
parameters = Map("dataType" -> "PhysicalCalendarIntervalType"))
}
+ test("SPARK-49634: Numeric value out of range") {
Review Comment:
Thanks, fully agree. I've kept the test but reworked it for the non-ANSI
case. Didn't move to QueryExecutionAnsiErrorsSuite as it already contains
similar tests.
Not sure it fits here -- I'll remove it if you consider it redundant.
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##########
@@ -1436,6 +1436,24 @@ class QueryExecutionErrorsSuite
parameters = Map("dataType" -> "PhysicalCalendarIntervalType"))
}
+ test("SPARK-49634: Numeric value out of range") {
Review Comment:
Interesting -- this was failing before the fix, as far as I remember. I'll
need a moment to recall the context to confirm the test does what's intended.
I'll also move it to the right place. Thanks for pointing this out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
