LukaZdravic commented on code in PR #58823:
URL: https://github.com/apache/spark/pull/58823#discussion_r4018064784
##########
sql/core/src/test/scala/org/apache/spark/sql/AsOfJoinSQLSuite.scala:
##########
@@ -200,14 +201,41 @@ class AsOfJoinSQLSuite extends QueryTest with
SharedSparkSession {
sqlState = Some("42K09"),
parameters = Map(
"type1" -> "\"TIMESTAMP\"",
- "type2" -> "\"STRING\""),
+ "type2" -> "\"DECIMAL(5,2)\""),
queryContext = Array(
ExpectedContext(
fragment = """ASOF JOIN quotes q
- | MATCH_CONDITION (t.trade_time >= q.symbol)
+ | MATCH_CONDITION (t.trade_time >= q.bid_price)
| ON t.symbol = q.symbol""".stripMargin,
start = 35,
- stop = 122)))
+ stop = 125)))
+ }
+
+ // SPARK-59527 reproduces with ANSI on and off, so both are checked.
+ Seq(true, false).foreach { ansi =>
+ test(s"MATCH_CONDITION coerces DATE vs STRING like the comparison operator
(ansi=$ansi)") {
+ withSQLConf(SQLConf.ANSI_ENABLED.key -> ansi.toString) {
+ // `l.d >= r.s` type-checks: the string is coerced to DATE, the same
as a bare `>=`
+ // comparison. Before SPARK-59527 this failed with INVALID_TYPE.
+ val sqlText =
+ """
+ |SELECT l.d, r.s
+ |FROM VALUES (DATE '2024-01-03') AS l(d) ASOF JOIN
+ | VALUES ('2024-01-01') AS r(s)
+ | MATCH_CONDITION (l.d >= r.s)
+ |""".stripMargin
+ val asOfJoin = sql(sqlText).queryExecution.analyzed.collectFirst {
+ case j: AsOfJoin => j
+ }.get
Review Comment:
`collectFirst { case j: AsOfJoin => j }.get` is the established pattern
throughout `AsOfJoinSQLSuite` (every analysis test uses it), so I kept it for
consistency with the surrounding tests. If the suite owners prefer
`getOrElse(fail(...))`, I am happy to switch them all in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
