LukaZdravic commented on PR #58823: URL: https://github.com/apache/spark/pull/58823#issuecomment-5715398953
> A few minor comments: > > 1. User-facing change is a bit wider than the PR text. > TypeCoercion.findWiderTypeForTwo used to return None for BOOLEAN/BINARY vs STRING (stringPromotion excludes both). Those pairs now go through the comparison common type and are accepted, same as >=. Worth one line in the PR description; a tiny test is optional. > 2. The SQL error file no longer has a STRING case. > FVT-ASOF-3-012 moved from TIMESTAMP vs STRING to TIMESTAMP vs DECIMAL. Interval rejection is only in AsOfJoinMatchConditionTypesSuite. A golden MATCH_CONDITION error for STRING vs INTERVAL YEAR TO MONTH would lock the new error class. > 3. Date/timestamp goldens do not prove sort/comparison agreement. > '2026-06-28' / '2026-06-29' sort the same as text and as dates. The INT query carries that; the date queries only show “analysis succeeds and the nearest ISO date matches.” Fine if that is intentional. > 4. Please consider adding a few cheap extra cases. > STRING on the left (t.s >= r.d), and TIMESTAMP_NTZ vs STRING (common type is NTZ via the AtomicType fallback, not the TimestampType special case). Thanks, fixed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
