hhr293 commented on PR #58424:
URL: https://github.com/apache/spark/pull/58424#issuecomment-5726872386

    Hi @peter-toth, thanks for the review! Pushed a follow-up addressing all 
three:
   
     1. Added the STRING/BINARY sort-aggregate caveat to the conf doc (findingĀ 
5).
     2. Added a positive test for the bare-outer-join branch (projectListOpt == 
None)
        using the shape you gave (findingĀ 8).
     3. Extended the ANSI NULL-equi-key test to loop 
constraintPropagation.enabled
        and assert the actual outcome per combination, instead of unconditional
        parity (findingĀ 7).
   
     No production code changes and PR description has been updated. Thank you 
again for your approve!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to