srielau commented on code in PR #58549: URL: https://github.com/apache/spark/pull/58549#discussion_r4049076440
########## python/pyspark/sql/types.py: ########## @@ -2868,7 +2868,7 @@ def _has_nulltype(dt: DataType) -> bool: def _has_type(dt: DataType, dts: Union[type, Tuple[type, ...]]) -> bool: - """Return whether there are specified types""" + """Return whether `dt` logically contains any of `dts`. Does not descend UDTs.""" Review Comment: Restored `_has_type` UDT-storage recursion and introduced `_has_logical_type` for logical CHAR/VARCHAR capability checks. `_has_physical_type` now delegates to the restored contract, with regression coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
