srielau commented on code in PR #58549:
URL: https://github.com/apache/spark/pull/58549#discussion_r4049733621
##########
python/pyspark/sql/tests/arrow/test_arrow.py:
##########
@@ -1433,6 +1441,137 @@ def test_toArrow_duplicate_field_names(self):
):
df.limit(0).toArrow()
+ def test_char_varchar_explicit_schema_and_to_arrow(self):
Review Comment:
Done. Moved both Classic-only tests
(`test_char_varchar_explicit_schema_and_to_arrow` and
`test_to_arrow_char_varchar_udt_storage_is_unsupported`) out of
`ArrowTestsMixin` into the concrete `ArrowTests` class, so `ArrowParityTests`
(Connect) no longer inherits them. Added a class comment explaining why they
are Classic-only.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/PythonUDF.scala:
##########
@@ -337,9 +337,14 @@ case class PythonUDF(
// single lambda, and one more for each enclosing lambda when the UDF is
lifted out of a nested
// lambda (e.g. `transform(arr, i -> transform(i, x -> f(x)))` lifts `f`
to depth 2). Ignored
// for every non-element-wise eval type, where it stays at its default of
1.
- elementwiseNestingDepth: Int = 1)
+ elementwiseNestingDepth: Int = 1,
+ // Original CHAR/VARCHAR result type when write-side checks apply. Absent
for unconstrained
+ // results so CHAR/VARCHAR policy is not part of PythonUDF equality.
Review Comment:
Done. Applied the suggested wording so the comment is complete sentences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
