peter-toth commented on PR #59165: URL: https://github.com/apache/spark/pull/59165#issuecomment-5937582338
@dongjoon-hyun, your broadcast join point on #59189 ([comment](https://github.com/apache/spark/pull/59189#discussion_r4158266417)) applies here too. `BroadcastHashJoinExec.expandOutputPartitioning` reports `bucket(4, id)` as `bucket(4, p.b + 1)` as well, so this PR's wrong result does not need `spark.sql.sources.v2.bucketing.shuffle.enabled`. With every conf at its default, `SELECT /*+ BROADCAST(p) */ ... FROM t1 JOIN plain p ON t1.id = p.b + 1 JOIN t3 ON p.b = t3.x` returns 0 of 7 rows on master. This PR already returns all 7 rows, since the guard does not depend on where the layout came from. [5375cc3](https://github.com/apache/spark/pull/59165/commits/5375cc3ca7bb8469c45c686ddfe3189eb6a250d3) adds a test for it, and I updated the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
