peter-toth commented on PR #59165: URL: https://github.com/apache/spark/pull/59165#issuecomment-5957282464
Thanks for round 2, @dongjoon-hyun, and for merging #59189. [765c526](https://github.com/apache/spark/pull/59165/commits/765c526071fd7c35ba80b518564272a344e64036) is rebased onto master and takes round 2. It goes further on item 1. Instead of only documenting the cost, it pairs the same argument shape again. Item 11 goes to SPARK-59900, and item 9 came with #59189. I also fixed the `Generated-by` line (item 15) and updated the description. Besides your items, [765c526](https://github.com/apache/spark/pull/59165/commits/765c526071fd7c35ba80b518564272a344e64036) pairs two transforms reduced through the same pairing over the same shape, as it does for columns. A new test checks that a different pairing is not paired. Since this PR fixes SPARK-59901, the SPARK-59905 test now runs its `p.b + p.c` query with AQE on too. The identity arm of `reducersBothWays` and `createPartitioning` now rebuild a transform through one helper, which asserts that its argument is a column. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
