Github user tarekauel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6804#discussion_r32690308
  
    --- Diff: 
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
    @@ -55,13 +55,17 @@ public static UTF8String fromString(String str) {
       /**
        * Updates the UTF8String with String.
        */
    -  public UTF8String set(final String str) {
    -    try {
    -      bytes = str.getBytes("utf-8");
    -    } catch (UnsupportedEncodingException e) {
    -      // Turn the exception into unchecked so we can find out about it at 
runtime, but
    -      // don't need to add lots of boilerplate code everywhere.
    -      PlatformDependent.throwException(e);
    +  protected UTF8String set(final String str) {
    +    if (str == null) {
    +      bytes = new byte[0];
    --- End diff --
    
    okay I am going to remove this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to