Github user tarekauel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6804#discussion_r32690645
  
    --- Diff: 
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
    @@ -178,6 +189,7 @@ public UTF8String clone() {
     
       @Override
       public int compareTo(final UTF8String other) {
    +    if (other == null) return 1;
    --- End diff --
    
    I think it should be able to sort columns with `null` values. The behavior 
should be compared to a database, shouldn't it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to