MaxGekk commented on PR #59225: URL: https://github.com/apache/spark/pull/59225#issuecomment-6032066638
Thank you for the third pass, @dongjoon-hyun. I checked all 11 against the code and they hold. Items 1-5 and 7-11 are addressed in 1edcb55e4b7, and I reply inline with what changed for each. Item 1: the UNPIVOT test now checks the shape of the generated code instead of Janino's message, and both compacted-slot tests pass with `SPARK_CODEGEN_COMPILER=jdk`. Item 6: I agree the `ExpandExec` relabel is the right fix and opened SPARK-60021 for it; I'd like to keep the slot rule here until that lands, and drop it in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
