MaxGekk commented on PR #59225: URL: https://github.com/apache/spark/pull/59225#issuecomment-6001968399
Thank you for the very thorough review, @dongjoon-hyun. I checked all 15 against the code and every one holds. They are addressed in b4ddb07889c, and I reply inline with what changed for each. Items 1 and 2: the decision key now covers what the recording depends on, and the marker strip skips literals. One literal-aware marker matcher now serves both the strip and the marker-to-method map, so the two cannot disagree again. Items 3, 5 and 6 went into one rework of `chooseCode`: one decision per key, unknown sizes treated as undecided, and no second trial when the split changes nothing. For item 5 I corrected the numbers and documented the per-run literal case in the description. I'd like to leave a literal-insensitive memo for a follow-up; the inline reply explains why. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
