dongjoon-hyun opened a new pull request, #587:
URL: https://github.com/apache/spark-connect-swift/pull/587

   ### What changes were proposed in this pull request?
   
   This PR aims to make the stored properties of `StreamingQueryStatus` 
(`statusMessage`, `isDataAvailable`, `isTriggerActive`, `isActive`) and 
`StreamingQueryException` (`exceptionMessage`, `errorClass`, `stackTrace`) 
`public`, with brief doc comments.
   
   ### Why are the changes needed?
   
   `StreamingQueryStatus` and `StreamingQueryException` are `public` structs 
returned by the public APIs `StreamingQuery.status()` and 
`StreamingQuery.exception()`, but their properties were `internal`. As a 
result, applications outside the `SparkConnect` module could not read any of 
the returned fields. For example, the following code failed to compile.
   
   ```swift
   let status = try await query.status()
   print(status.isActive)  // error: 'isActive' is inaccessible due to 
'internal' protection level
   ```
   
   This aligns with PySpark, where `StreamingQuery.status` and 
`StreamingQuery.exception()` expose this information to users.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Users can now read the fields of `StreamingQueryStatus` and 
`StreamingQueryException`. This is an additive API change only.
   
   ### How was this patch tested?
   
   Pass the CIs with the newly added `StreamingQueryTests.status` test case.
   
   In addition, I manually verified that an out-of-module Swift package 
depending on `SparkConnect` fails to compile before this PR and compiles after 
this PR when it accesses these properties.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 5.5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to