LukaZdravic commented on code in PR #59267:
URL: https://github.com/apache/spark/pull/59267#discussion_r4218881096
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/RetainsOriginalJoinOutput.scala:
##########
@@ -112,7 +112,9 @@ trait RetainsOriginalJoinOutput {
* [[Project]] on top of the outer [[Join]] even though its output has
changed.
*
* The above example also holds true for cases when there is a [[Project]],
[[Aggregate]] or
- * [[Filter]] node on top of a [[Join]].
+ * [[Filter]] node on top of a [[Join]]. An [[AsOfJoin]] is handled the same
way, because
Review Comment:
Done
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveAsOfJoin.scala:
##########
@@ -74,10 +74,11 @@ object ResolveAsOfJoin extends Rule[LogicalPlan] with
SQLConfHelper {
}
val resolvedJoin = (matchLeft, matchOp, matchRight) match {
case (Some(leftExpr), Some(operator), Some(rightExpr)) =>
+ // Include hidden columns, such as the dropped key of a nested USING
join.
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
