LukaZdravic commented on code in PR #59267:
URL: https://github.com/apache/spark/pull/59267#discussion_r4218898249
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/RetainsOriginalJoinOutput.scala:
##########
@@ -127,10 +129,30 @@ trait RetainsOriginalJoinOutput {
referencedAttributes = childReferencedAttributes
) =>
Project(scopes.current.output, join)
+ case asOfJoin: AsOfJoin
+ if childHasMissingAttributesNotInOutput(
+ scopes = scopes,
+ outputExpressions = outputExpressions,
+ referencedAttributes = referencedAttributesOf(asOfJoin)
+ ) =>
+ Project(scopes.current.output, asOfJoin)
Review Comment:
Yes, I agree, the fix itself isn't that big I checked but it does touch all
the joins and is not related to ASOF, so I can fix it in follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
