HyukjinKwon commented on PR #59305:
URL: https://github.com/apache/spark/pull/59305#issuecomment-6138129760
Thanks, the gate answers my earlier question. I checked that the
`file_type_enabled` predicate covers both `FILE` and `FILE EXTERNAL`, that
`failUnsupportedDataType` rejects nested FILE types with
`UNSUPPORTED_FILE_TYPE`, and that JSON parsing stays ungated like the
nanosecond timestamp types. One gap:
`SqlStatementSplitter.configureSplitterParser` copies the other session grammar
flags but not `file_type_enabled`, so with the flag on, the spark-sql CLI and
`parse_sql` split a `BEGIN ... END` block containing `FILE EXTERNAL` at its
inner semicolons. I left an inline comment on `parsers.scala`.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6126981900","thread_id":"conversation:6126981900","verdict_sha256":"c57df3415da184350093919a4d0cfa68ecaef3a3409a1884746fc2fbe99c2a0c"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
