dejankrak-db commented on PR #59305: URL: https://github.com/apache/spark/pull/59305#issuecomment-6149534107
On the question about `DataTypes.FileType`: no, the UNKNOWN constant was not meant to be the Java entry point. A `DataTypes.FileType` added to a schema gives the UNKNOWN mode, and the field reads back as external after a JSON round trip, so I removed the constant from this PR (17f9984a5ce). A type with a parameter has a factory in `DataTypes`, so a Java entry point for the type, either a factory with the mode or a constant for the column mode, can be added together with the Java API of the type, once that is designed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
