HyukjinKwon commented on PR #59402:
URL: https://github.com/apache/spark/pull/59402#issuecomment-6195900424
Thanks for the follow-up. I checked d22c01a: `canGuard` now also requires
every filter to be free of `PLAN_EXPRESSION`, and `extractCondAndBase` leaves
an IF/CASE whose condition contains a subquery un-normalized, so IN / NOT IN /
EXISTS filters keep the raw Expand key and one existence join per predicate.
The new conf-on/conf-off existence-join tests in
`RewriteDistinctAggregatesConditionalQuerySuite` would catch a second join, and
`RewriteDistinctAggregatesSuite` pins both exclusions. The two PR description
updates match the code as well.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6194201223","thread_id":"conversation:6194201223","verdict_sha256":"335312eb41a731898687a823ef16ff33f1bd99e1615a48a258a2f282f9117240"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
