xumingming commented on PR #59402: URL: https://github.com/apache/spark/pull/59402#issuecomment-6230948385
Thanks for the thorough reviews, @HyukjinKwon and @cloud-fan! The findings from the latest two review rounds are addressed: 1. `b4788651a73`: conditional counts now stay in a shared IF group when another distinct aggregate keeps that group. 2. `b4788651a73`: the non-distinct COUNT regression now reaches normalization and verifies its raw IF child and missing FILTER. 3. `4a8ee100f5e`: the config doc now covers deterministic, subquery-free filters and subquery-bearing conditions. 4. `4a8ee100f5e`: the config doc and PR description now document the OptimizeExpand tradeoff and [SPARK-60318](https://issues.apache.org/jira/browse/SPARK-60318). Validation: `RewriteDistinctAggregatesSuite` passes locally (35/35 tests). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
