spark-test commented on PR #59708:
URL: https://github.com/apache/spark/pull/59708#issuecomment-6349922671
Thanks, the fixes for items 1-3 look right on 2233a6b. Parsing twice in
update_jira_for_pr is cheap and keeps unwrap and fallback in leading_jira_ids,
so there is no need to refactor. One small gap remains: _unwrap_title strips
only one wrapper level, so a revert-of-revert title still loses its id. See the
comment on dev/merge_spark_pr.py.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6343253163","thread_id":"conversation:6343253163","verdict_sha256":"15bf7ee0016037bed6132d23d99ae13a35a6805003291c36e9b3ae1e1d6a08a6"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
