sarutak commented on PR #59708: URL: https://github.com/apache/spark/pull/59708#issuecomment-6371769688
Pushed 3b0e10e with two small changes of my own, and updated the PR description. No behavior change for real titles. - The nested-wrapper cases in the `update_jira_for_revert` doctest now use `Revert "Reapply "...""` instead of `Revert "Revert "...""` with `is_revert=True`. `Revert "Reapply "...""` is a revert both by its outermost wrapper, which is how `main()` decides today, and by wrapper nesting, so the doctest no longer pins the revert path for a re-land, which the planned wrapper-parity change will fix. - `_BARE_SPARK_ID_RE` now adds `re.ASCII`, so its case-insensitive match no longer accepts Unicode lookalikes such as U+017F for `s` or U+212A for `K`. That makes "the same ASCII digits and case as the bracket path" in my previous comment exactly true. I also added a doctest for a 6-digit id. The description now also notes that an id may have any number of digits (the old regex missed ids below `SPARK-1000` and read `SPARK-123456` as `SPARK-12345`), and that the only wrapped subjects in master's history that now yield fewer ids drop a body reference. It also corrects a mistake that was in both the description and my previous comment: `Revert "[WIP] [SPARK-3996]: Shade Jetty in Spark deliverables"` is from 2015, not 2014. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
