vranes commented on code in PR #59834:
URL: https://github.com/apache/spark/pull/59834#discussion_r4402722976
##########
sql/core/src/test/scala/org/apache/spark/sql/SortMergeAsOfJoinSuite.scala:
##########
@@ -1244,52 +1347,254 @@ class SortMergeAsOfJoinSuite extends QueryTest
}
gridTest("nearest join rejects STRING keys during analysis")(Seq(false,
true)) { singlePass =>
- // With ANSI on, analysis already rejects the subtraction of two strings.
withAsOfJoinAnalyzer(singlePass) {
- withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {
- val left = spark.sql("SELECT '50' AS k")
- val right = spark.sql("SELECT '10' AS k, 'ten' AS tag")
+ for (ansi <- Seq(false, true)) {
+ withSQLConf(
+ SQLConf.SORT_MERGE_AS_OF_JOIN_ENABLED.key -> "true",
Review Comment:
Added flag-off nearest STRING rejection tests and off-to-on strategy tests
for both a DataFrame and a temp view, under both analyzers. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
