vranes commented on code in PR #59834:
URL: https://github.com/apache/spark/pull/59834#discussion_r4402741746
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveAsOfJoin.scala:
##########
@@ -18,279 +18,80 @@
package org.apache.spark.sql.catalyst.analysis
import org.apache.spark.sql.catalyst.SQLConfHelper
-import org.apache.spark.sql.catalyst.expressions.{
- Cast,
- Expression,
- GreaterThan,
- If,
- SubqueryExpression,
- SubtractTimestamps,
- WindowExpression
-}
import org.apache.spark.sql.catalyst.expressions.AttributeSet
-import org.apache.spark.sql.catalyst.expressions.aggregate.AggregateExpression
-import org.apache.spark.sql.catalyst.plans.{AsOfJoinDirection,
MatchComparisonOperator}
import org.apache.spark.sql.catalyst.plans.logical.{AsOfJoin, LogicalPlan}
-import org.apache.spark.sql.catalyst.plans.logical.AsOfJoin.MatchConditionTypes
import org.apache.spark.sql.catalyst.rules.Rule
-import org.apache.spark.sql.catalyst.trees.TreePattern.{AS_OF_JOIN, GENERATOR}
+import org.apache.spark.sql.catalyst.trees.TreePattern.AS_OF_JOIN
import org.apache.spark.sql.catalyst.util._
-import org.apache.spark.sql.errors.QueryErrorsBase
-import org.apache.spark.sql.types.{DataType, StringType, TimestampFamily}
/**
- * Resolves SQL [[AsOfJoin]] operators: materializes `MATCH_CONDITION` into
the fields of
+ * Resolves [[AsOfJoin]] operators: materializes `MATCH_CONDITION` into the
fields of
Review Comment:
Updated the scaladoc to cover DataFrame keys, tolerance validation, and
strategy selection during analysis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
