urosstan-db commented on code in PR #59671:
URL: https://github.com/apache/spark/pull/59671#discussion_r4415737435
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala:
##########
@@ -151,11 +153,28 @@ class JDBCTableCatalog extends TableCatalog
}
}
+ // The per-read value decides the resolved schema, so it must reach
loadTable.
+ override def tableStateOptionKeys(): util.Set[String] =
Review Comment:
Yes, it is nice you found this gap, but I would keep it as potential
follow-up, since impact is a little bit wider while benefit is small (we change
case sensitivity of map in JDBCOptions, so it is a little bit hard to reason
about all subtle changes in the PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
