urosstan-db commented on code in PR #59671:
URL: https://github.com/apache/spark/pull/59671#discussion_r4423365070
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala:
##########
@@ -154,8 +154,7 @@ class JDBCTableCatalog extends TableCatalog
override def loadTable(ident: Identifier): Table = {
JdbcUtils.withConnection(options) { conn =>
val tableOptions = new JDBCOptions(
- options.parameters + (JDBCOptions.JDBC_TABLE_NAME ->
getTableName(ident)) +
- (JDBCOptions.JDBC_TIMESTAMP_NTZ_WALL_CLOCK ->
dialect.timestampNTZAsWallClock.toString))
+ options.parameters + (JDBCOptions.JDBC_TABLE_NAME ->
getTableName(ident)))
Review Comment:
Just to double check: Options comes from catalog initialize, so if user set
spark conf for initialize, we propagate it, otherwise we use default in
JDBCOptions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
