dbtsai commented on PR #140: URL: https://github.com/apache/spark-connect-rust/pull/140#issuecomment-6676421423
Thank you for working on this and for the regression coverage. The typed execution and analysis requests still need this fix. I've opened [SPARK-60989](https://issues.apache.org/jira/browse/SPARK-60989) to track it, so you can use that key in the PR title and replace the pending-issue note in the description. Could you please rebase onto current master and refresh the patch and validation results? A few points to keep in mind: - Keep the remaining change focused on typed request context. #164 already landed the artifact attribution changes; please retain the shared `upload_artifact_requests` stamping point. - Preserve caller-provided IDs, user names, and extensions, and populate a missing ID before constructing the reattachable stream so its subsequent requests inherit the effective context. Raw serialized passthrough requests should remain byte-exact. - Adapt the transport tests to master's current execution cleanup and verify the context on actual `ReattachExecute` and `ReleaseExecute` requests, including cleanup after completion and early stream drop. Since releases now run asynchronously, the tests should wait for the expected cleanup requests rather than rely on a fixed total request count or only inspect a constructed release request. Broader `client_type` propagation can remain separate. Thanks again for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
