dbtsai opened a new pull request, #285:
URL: https://github.com/apache/spark-connect-rust/pull/285

   ### What changes were proposed in this pull request?
   
   PR #169 aligned Rust `DataFrame::print_schema()` with the reference trailing 
blank line, but its exact Rust stdout check was not committed. Add an offline 
regression that calls the real method in a child process and asserts exact 
output for nested and empty cached schemas. A 30-second child watchdog bounds 
cache/RPC regressions. Document the intentional final blank line; production 
behavior and public APIs are unchanged.
   
   ### Why are the changes needed?
   
   Keep the output contract from 
[SPARK-60695](https://issues.apache.org/jira/browse/SPARK-60695) under durable 
regression coverage. Python stdout tests exercise a separate print path. The 
new test fails when the native `println!` is temporarily changed back to 
`print!`.
   
   ### How was this patch tested?
   
   - 462 Rust release library tests passed, including the actual-stdout 
regression; the negative newline mutation failed as expected and was restored.
   - All client integration targets compiled with and without `wasm-udf`; 
formatting and whitespace checks passed.
   - Fresh native Python extension release build passed; 14 focused Python 
schema tests passed.
   - Official Spark 4.3 type-parity gate: 70 passed, 21 skipped on an isolated 
UTC server with `spark.sql.timeType.enabled=true`. The initial TIME-disabled 
failure reproduced with official PySpark before correcting the server 
configuration.
   - Twelve-class attribute-name comparison found zero unexpected missing 
public names; the documented `Column.to_plan` transport gap and inherited 
private/dunder differences remain visible. This is not a claim of complete 
behavioral parity.
   - Genuine local Claude Code reviewed the original landed patch twice and the 
complete follow-up patch, assessed all findings/nits, and approved this final 
source with no defects.
   
   Draft pending broader repository validation: workspace Clippy exits 101 with 
14 existing approximate-constant errors in files byte-identical to the base 
(source audit, not a separate baseline Clippy run). The complete official 
Connect suite and CI have not been certified by these scoped checks.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: OpenAI Codex (GPT-6), with independent local Claude Code 
review.
   
   This pull request and its description were written by Isaac.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to