Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6876#discussion_r32790173
  
    --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/BaseRow.java ---
    @@ -155,27 +155,6 @@ public int fieldIndex(String name) {
         throw new UnsupportedOperationException();
       }
     
    -  /**
    -   * A generic version of Row.equals(Row), which is used for tests.
    -   */
    -  @Override
    --- End diff --
    
    Because `Row` is a trait, UnsafeRow and SpecificRow are both in Java, they 
can not inherit some default implementations from `Row`, so created BaseRow in 
Java for them. Right now, we have `InternalRow`, will be clean these in another 
PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to