Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32799402
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -26,7 +26,67 @@ import
org.apache.spark.sql.catalyst.expressions.GenericRow
*/
abstract class InternalRow extends Row {
// A default implementation to change the return type
- override def copy(): InternalRow = {this}
+ override def copy(): InternalRow = this
+
+ override def equals(o: Any): Boolean = {
+ if (!o.isInstanceOf[Row]) {
+ return false
+ }
+
+ val other = o.asInstanceOf[Row]
+ if (length != other.length) {
+ return false
+ }
+
+ for (i <- 0 until length) {
--- End diff --
I think we should use `while` here, as `for` is inefficient in scala.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
