Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32804448
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/LiteralExpressionSuite.scala
---
@@ -31,8 +45,16 @@ class LiteralExpressionSuite extends SparkFunSuite with
ExpressionEvalHelper {
}
test("int literals") {
- checkEvaluation(Literal(1), 1)
- checkEvaluation(Literal(0L), 0L)
+ List(0, 1, Int.MinValue, Int.MaxValue).foreach {
--- End diff --
this is a pretty weird way of indenting. you can do
```scala
List(0, 1, Int.MinValue, Int.MaxValue).foreach { d =>
...
}
```
or
```scala
for (d <- List(0, 1, Int.MinValue, Int.MaxValue)) {
...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
