GitHub user dragos opened a pull request:

    https://github.com/apache/spark/pull/6903

    [SPARK-7944] Remove most of the Spark REPL fork for Scala 2.11

    This PR removes most of the code in the Spark REPL for Scala 2.11 and 
leaves just a couple of overridden methods in `SparkILoop` in order to:
    
    - change welcome message
    - restrict available commands (like `:power`)
    - initialize Spark context
    
    The two codebases have diverged and it's extremely hard to backport fixes 
from the upstream REPL. This somewhat radical step is absolutely necessary in 
order to fix other REPL tickets (like SPARK-8013 - Hive Thrift server for 
2.11). BTW, the Scala REPL has fixed the serialization-unfriendly wrappers 
thanks to @ScrapCodes's work in 
[#4522](https://github.com/scala/scala/pull/4522)
    
    All tests pass and I tried the `spark-shell` on our Mesos cluster with some 
simple jobs (including with additional jars), everything looked good.
    
    As soon as Scala 2.11.7 is out we need to upgrade and get a shaded `jline` 
dependency, clearing the way for SPARK-8013.
    
    /cc @pwendell 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dragos/spark issue/no-spark-repl-fork

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/6903.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6903
    
----
commit abcc7cb91c259dde3cba3530b61cabe7af594195
Author: Iulian Dragos <jagua...@gmail.com>
Date:   2015-06-19T08:41:26Z

    Remove the REPL forked code.

commit 9d46d85cd8aa0665405ee909ade6c5d6fd007efd
Author: Iulian Dragos <jagua...@gmail.com>
Date:   2015-06-19T12:51:25Z

    Fix SPARK-7944.
    
    Make sure the class path is correctly passed to the underlying REPL.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to