Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6814#discussion_r32847142
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
    @@ -261,7 +261,7 @@ final class Decimal extends Ordered[Decimal] with 
Serializable {
     
       def - (that: Decimal): Decimal = Decimal(toBigDecimal - 
that.toBigDecimal)
     
    -  def * (that: Decimal): Decimal = Decimal(toBigDecimal * 
that.toBigDecimal)
    +  def * (that: Decimal): Decimal = 
Decimal(toJavaBigDecimal.multiply(that.toJavaBigDecimal))
    --- End diff --
    
    However, as decimal type in Hive is based on Java's BigDecimal. As I 
tested, Hive can output the accurate result of `select CAST(9223372036854775807 
as DECIMAL(38,0)) * CAST(9223372036854775807 as DECIMAL(38,0));`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to