Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6814#discussion_r32850052
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -261,7 +261,7 @@ final class Decimal extends Ordered[Decimal] with
Serializable {
def - (that: Decimal): Decimal = Decimal(toBigDecimal -
that.toBigDecimal)
- def * (that: Decimal): Decimal = Decimal(toBigDecimal *
that.toBigDecimal)
+ def * (that: Decimal): Decimal =
Decimal(toJavaBigDecimal.multiply(that.toJavaBigDecimal))
--- End diff --
I think this can be fixed by in `toBigDecimal`:
```
BigDecimal(longVal, _scale, new MathContext(precision,
RoundingMode.HALF_EVEN))
```
Also, in order to have the same behavior as other datebase or Hive, we
should throw an exception if precision is higher than 38.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
