Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6814#discussion_r32869361 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/decimal/DecimalSuite.scala --- @@ -162,4 +162,9 @@ class DecimalSuite extends SparkFunSuite with PrivateMethodTester { assert(new Decimal().set(100L, 10, 0).toUnscaledLong === 100L) assert(Decimal(Long.MaxValue, 100, 0).toUnscaledLong === Long.MaxValue) } + + test("accurate precision after multiplication") { + val decimal = (Decimal(Long.MaxValue, 100, 0) * Decimal(Long.MaxValue, 100, 0)).toJavaBigDecimal --- End diff -- We can use 38 in this test case
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org