Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/6814#discussion_r32881564
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -286,6 +288,9 @@ object Decimal {
/** Maximum number of decimal digits a Long can represent */
val MAX_LONG_DIGITS = 18
+ /** Maximum precision a Decimal can support */
+ val MAX_PRECISION = 38
--- End diff --
ok. however, with the customized `MathContext` approach, we can not
determine the needed precision needed for later decimal operations like
multiplication without losing precision reported in the JIRA. Directly using
java decimal to do these operations can avoid this problem as showed in first
commit. Do we want to use it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
