Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6911#issuecomment-114226149
This looks good to me overall. I like the idea of storing the length in
the fixed-length values section alongside the pointer to the variable-length
data. I wonder whether there's a natural point to document / explicitly call
out this encoding, though, in order to make it a bit more obvious to any new
readers of this file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
