Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6911#discussion_r32976895
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverter.scala
---
@@ -72,6 +70,19 @@ class UnsafeRowConverter(fieldTypes: Array[DataType]) {
*/
def writeRow(row: InternalRow, baseObject: Object, baseOffset: Long):
Int = {
unsafeRow.pointTo(baseObject, baseOffset, writers.length, null)
+
+ if (writers.length > 0) {
--- End diff --
I think that we need to change this to `>=` then. If you look at the line
below, on line 77, when `writers.length` == 0 then `n == 0` but the loop
implies that we'll still allocate one word for null-tracking bits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
