Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4055#discussion_r33077937
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1193,8 +1193,10 @@ class DAGScheduler(
// TODO: This will be really slow if we keep accumulating shuffle
map stages
for ((shuffleId, stage) <- shuffleToMapStage) {
stage.removeOutputsOnExecutor(execId)
- val locs = stage.outputLocs.map(list => if (list.isEmpty) null
else list.head).toArray
- mapOutputTracker.registerMapOutputs(shuffleId, locs, changeEpoch
= true)
+ if (!runningStages.contains(stage)) {
--- End diff --
The additional test passes without this change. Is this necessary for
correctness? If so, we need a better test for it. If its not for correctness,
and just an optimization, I'm a little hesitant about including it, I'd to
better understand why it would help.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
