Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/4055#discussion_r33081062
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -598,6 +598,59 @@ class DAGSchedulerSuite
assertDataStructuresEmpty()
}
+ test("run with ShuffleMapStage retry") {
+ val firstRDD = new MyRDD(sc, 3, Nil)
+ val firstShuffleDep = new ShuffleDependency(firstRDD, null)
+ val firstShuffleId = firstShuffleDep.shuffleId
+ val shuffleMapRdd = new MyRDD(sc, 3, List(firstShuffleDep))
+ val shuffleDep = new ShuffleDependency(shuffleMapRdd, null)
+ val reduceRdd = new MyRDD(sc, 1, List(shuffleDep))
+ submit(reduceRdd, Array(0))
+
+ complete(taskSets(0), Seq(
+ (Success, makeMapStatus("hostB", shuffleMapRdd.partitions.size)),
+ (Success, makeMapStatus("hostB", shuffleMapRdd.partitions.size)),
+ (Success, makeMapStatus("hostA", shuffleMapRdd.partitions.size))
+ ))
+
+ complete(taskSets(1), Seq(
+ (Success, makeMapStatus("hostA", reduceRdd.partitions.size)),
+ (Success, makeMapStatus("hostB", reduceRdd.partitions.size))
+ ))
+ runEvent(ExecutorLost("exec-hostA"))
+ // Resubmit already succcessd in hostA task
+ runEvent(CompletionEvent(taskSets(1).tasks(0), Resubmitted,
+ null, null, createFakeTaskInfo(), null))
+
+ // Cause mapOutTracker remove hostA outputs for taskset(0).
+ // Task that resubmitted will fetch matadata failed.
+ runEvent(CompletionEvent(taskSets(1).tasks(0),
+ FetchFailed(null, firstShuffleId, 2, 0, "Fetch failed"),
+ null, null, createFakeTaskInfo(), null))
+
+ // FetchFailed cause resubmit failed Stages.
+ scheduler.resubmitFailedStages()
+
+ runEvent(CompletionEvent(taskSets(0).tasks(2), Success,
+ makeMapStatus("hostC", shuffleMapRdd.partitions.size), null,
createFakeTaskInfo(), null))
--- End diff --
sorry, ignore the above comment -- I see that it is testing exactly what
you wanted it to test. But I think there are changes to be made in this test
below ... I need to play with it a bit more
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
