Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r33257058
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -662,6 +662,7 @@ private[spark] class TaskSetManager(
val failureReason = s"Lost task ${info.id} in stage ${taskSet.id} (TID
$tid, ${info.host}): " +
reason.asInstanceOf[TaskFailedReason].toErrorString
+ var failureException: Option[Throwable] = None
reason match {
--- End diff --
you could avoid using a `var` by making the exception the result of the
entire match block, eg.
```scala
val failureException: Option[Throwable] = reason match {
...
```
honestly I don't have a strong opinion ... its nice to use a `val` so you
know the value is set by the `match` block, but OTOH the `match` block is so
big that is might be a bit hard to follow what is being returned ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
