Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r33257851
--- Diff: core/src/test/scala/org/apache/spark/FailureSuite.scala ---
@@ -139,5 +139,32 @@ class FailureSuite extends SparkFunSuite with
LocalSparkContext {
FailureSuiteState.clear()
}
+ test("failure cause is sent back to driver") {
+ sc = new SparkContext("local", "test")
+ val data = sc.makeRDD(1 to 3).map(x => { throw new
IllegalStateException("oops"); (x,
+ x) }).groupByKey(3)
+ val thrown = intercept[SparkException] {
+ data.collect()
+ }
+ assert(thrown.getClass === classOf[SparkException])
+ assert(thrown.getCause.getClass === classOf[IllegalStateException])
+ }
--- End diff --
super minor, but can you also check the contents of the
`IllegalStateException`? I'm sure its fine in your implementation, but might
as well add a check that we don't regress and somehow don't serialize the full
exception
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
