Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33276680
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -86,10 +89,106 @@ private[mesos] trait MesosSchedulerUtils extends
Logging {
/**
* Get the amount of resources for the specified type from the resource
list
*/
- protected def getResource(res: List[Resource], name: String): Double = {
+ protected def getResource(res: JList[Resource], name: String): Double = {
for (r <- res if r.getName == name) {
return r.getScalar.getValue
}
0.0
}
+
+
+ /** Helper method to get the key,value-set pair for a Mesos Attribute
protobuf */
+ private[mesos] def getAttribute(attr: Attribute): (String, Set[String]) =
--- End diff --
the whole trait is `private[mesos]`, so adding `private[mesos]` here is
unnecessary (but doesn't hurt)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
