Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5563#issuecomment-115322472
I left a handful of minor comments, but overall looks good. I'll defer to
@tnachen on the correctness of the mesos interaction. My one concern is about
testing. There aren't any tests which directly check whether the attributes
are used correctly. For that matter, are there no tests with a "real" mesos
cluster at all? I'm not super familiar w/ the mesos code, but I poked around a
few test classes and none of them seem to use a complete mesos cluster.
If that is really the case, I'd just like to hear that somebody has tried
this out on a real cluster with some minimal example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
