Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/6648#discussion_r33625132
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleManager.scala ---
@@ -50,15 +53,30 @@ private[spark] class HashShuffleManager(conf:
SparkConf) extends ShuffleManager
}
/** Get a writer for a given partition. Called on executors by map
tasks. */
- override def getWriter[K, V](handle: ShuffleHandle, mapId: Int, context:
TaskContext)
- : ShuffleWriter[K, V] = {
- new HashShuffleWriter(
- shuffleBlockResolver, handle.asInstanceOf[BaseShuffleHandle[K, V,
_]], mapId, context)
+ override def getWriter[K, V](
+ handle: ShuffleHandle,
+ mapId: Int,
+ stageAttemptId: Int,
+ context: TaskContext): ShuffleWriter[K, V] = {
+ addShuffleAttempt(handle.shuffleId, stageAttemptId)
+ new HashShuffleWriter(shuffleBlockResolver,
handle.asInstanceOf[BaseShuffleHandle[K, V, _]],
--- End diff --
Some sort of recognition at ShuffleManger.getWriter that addShuffleAttempt
must occur is needed. The bare minimum would be the additional commentary that
I requested earlier; but even better would be if we can make the compiler
enforce the requirement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
